Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-569] Fix ngClass error on item content #13235

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Feb 3, 2025

🎟️ Tracking

CL-569

📔 Objective

There was a non-conflicting change merged after CL-569 was merged that caused failures for the item content component. This PR fixes the error.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vleague2 vleague2 requested a review from a team as a code owner February 3, 2025 20:33
@vleague2 vleague2 enabled auto-merge (squash) February 3, 2025 20:34
@vleague2 vleague2 merged commit 3c01abc into main Feb 3, 2025
73 of 74 checks passed
@vleague2 vleague2 deleted the uif/cl-569/item-content-error branch February 3, 2025 20:43
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.49%. Comparing base (e5ffc16) to head (cf36987).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13235   +/-   ##
=======================================
  Coverage   35.49%   35.49%           
=======================================
  Files        3008     3008           
  Lines       90916    90917    +1     
  Branches    16914    16914           
=======================================
+ Hits        32273    32274    +1     
  Misses      56141    56141           
  Partials     2502     2502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Logo
Checkmarx One – Scan Summary & Details866dc45f-bcc3-4fb1-9501-1c0b240db3f9

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants