-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(active-user-state-refactor): [PM-18052] Jit Bug with SSO Service #13292
Merged
Patrick-Pimentel-Bitwarden
merged 7 commits into
main
from
auth/pm-18052/jit-bug-with-sso-service
Feb 6, 2025
Merged
fix(active-user-state-refactor): [PM-18052] Jit Bug with SSO Service #13292
Patrick-Pimentel-Bitwarden
merged 7 commits into
main
from
auth/pm-18052/jit-bug-with-sso-service
Feb 6, 2025
+24
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…- Fixed location of retrieving the active user id in one component.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13292 +/- ##
==========================================
- Coverage 35.10% 35.10% -0.01%
==========================================
Files 3031 3031
Lines 92515 92510 -5
Branches 16838 16838
==========================================
- Hits 32480 32475 -5
Misses 57581 57581
Partials 2454 2454 ☔ View full report in Codecov by Sentry. |
…- Fixed up type safety.
Great job, no security vulnerabilities found in this Pull Request |
…- Removed unnessesary subscriptions.
JaredSnider-Bitwarden
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18052
📔 Objective
📸 Screenshots
TDE New User JIT Provisioning Flow
Screen.Recording.2025-02-06.at.11.24.21.AM.mov
Master Password JIT Provisioning Flow
Screen.Recording.2025-02-06.at.11.36.25.AM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes