Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(active-user-state-refactor): [PM-18052] Jit Bug with SSO Service #13292

Merged

Conversation

Patrick-Pimentel-Bitwarden
Copy link
Contributor

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden commented Feb 6, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18052

📔 Objective

  • Fixed location of retrieving the active user id before setting the ActiveUserOrganizationSsoIdentifier.
  • Changed the warning to an error to be able to find the bug quicker.
  • Fixed some strict typings.

📸 Screenshots

TDE New User JIT Provisioning Flow

Screen.Recording.2025-02-06.at.11.24.21.AM.mov

Master Password JIT Provisioning Flow

Screen.Recording.2025-02-06.at.11.36.25.AM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…- Fixed location of retrieving the active user id in one component.
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 35.10%. Comparing base (0b5b1b3) to head (02dd6c1).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
libs/auth/src/angular/sso/sso.component.ts 0.00% 2 Missing ⚠️
libs/angular/src/auth/components/sso.component.ts 50.00% 0 Missing and 1 partial ⚠️
...nents/two-factor-auth/two-factor-auth.component.ts 50.00% 0 Missing and 1 partial ⚠️
...ngular/src/auth/components/two-factor.component.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13292      +/-   ##
==========================================
- Coverage   35.10%   35.10%   -0.01%     
==========================================
  Files        3031     3031              
  Lines       92515    92510       -5     
  Branches    16838    16838              
==========================================
- Hits        32480    32475       -5     
  Misses      57581    57581              
  Partials     2454     2454              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Logo
Checkmarx One – Scan Summary & Details33894455-8fc1-4da2-ae6b-6828b18cc510

Great job, no security vulnerabilities found in this Pull Request

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden marked this pull request as ready for review February 6, 2025 16:26
@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden requested a review from a team as a code owner February 6, 2025 16:26
@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden requested review from rr-bw and JaredSnider-Bitwarden and removed request for rr-bw February 6, 2025 16:26
@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden merged commit 516246e into main Feb 6, 2025
93 of 94 checks passed
@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden deleted the auth/pm-18052/jit-bug-with-sso-service branch February 6, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants