Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-1143] Remove Visual Studio Code Generation Package #2749

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

justindbaur
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Get rid of Microsoft.VisualStudio.Web.CodeGeneration.Design package since it is not utilized and just creates extra tech debt of versions to keep up to date.

Code changes

  • *.csproj: Removed the package reference to Microsoft.VisualStudio.Web.CodeGeneration.Design since it is used to help scaffold Controllers and Identity but most developers here don't even use Visual Studio so we have decided to get rid of it.
  • Directory.Build.props: Get rid of unused property for tracking package version.
  • All other changes are made by dotnet restore --force-evaluate

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@justindbaur justindbaur requested a review from a team February 27, 2023 18:00
@MGibson1
Copy link
Member

Fixes #2735

Copy link
Member

@MGibson1 MGibson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Only question is that comment may have been a convenience thing, but clearly no real impact.

Directory.Build.props Show resolved Hide resolved
@justindbaur justindbaur requested a review from MGibson1 February 28, 2023 13:12
MGibson1
MGibson1 previously approved these changes Mar 2, 2023
Copy link
Member

@MGibson1 MGibson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@justindbaur justindbaur merged commit 388caa2 into master Mar 14, 2023
@justindbaur justindbaur deleted the remove-visual-studio-code-generation branch March 14, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants