[PM-15807]Move subscription to 'canceled' 7 days after unpaid #5208
+107
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cy Okeke <[email protected]>
|
Fixed Issues
|
Signed-off-by: Cy Okeke <[email protected]>
jonashendrickx
requested changes
Jan 2, 2025
| Status = "open", | ||
| Subscription = subscriptionId | ||
| }; | ||
| var invoices = await stripeFacade.ListInvoices(options); |
There was a problem hiding this comment.
@cyprain-okeke The default pagination size is 10. This means you can only cancel 10 unpaid subscriptions per week if I'm understanding it correctly. If I misunderstood, feel free to dismiss my comment.
There was a problem hiding this comment.
You are right, I added some changes for when is more than default
Signed-off-by: Cy Okeke <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5208 +/- ##
==========================================
- Coverage 43.69% 43.65% -0.05%
==========================================
Files 1469 1470 +1
Lines 67898 67965 +67
Branches 6156 6164 +8
==========================================
Hits 29670 29670
- Misses 36934 37001 +67
Partials 1294 1294 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Cy Okeke <[email protected]>
…nceled-7-days-after-unpai'' into pm-15807-Move-subscription-to-canceled-7-days-after-unpai'
cyprain-okeke
changed the title
cyprain-okeke
deleted the
pm-15807-Move-subscription-to-canceled-7-days-after-unpai'
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15807
📔 Objective
7 days after a subscription moves to an unpaid status, we cancel the subscription.
we void any associated invoices
CS needs some way to override this behavior. Could be as simple as their current workflow, which is to mark the org as enabled.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes