Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16196] #5225

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[PM-16196] #5225

wants to merge 1 commit into from

Conversation

jonashendrickx
Copy link
Member

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-16196

๐Ÿ“” Objective

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner January 7, 2025 14:28
@jonashendrickx jonashendrickx added the hold Hold this PR or item until later; DO NOT MERGE label Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 43.70%. Comparing base (2a6abb9) to head (0ae36e8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5225   +/-   ##
=======================================
  Coverage   43.70%   43.70%           
=======================================
  Files        1472     1472           
  Lines       67963    67963           
  Branches     6161     6161           
=======================================
  Hits        29703    29703           
  Misses      36963    36963           
  Partials     1297     1297           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 0bf69757-bea6-4fdc-a496-2c5ccdba827c

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Hold this PR or item until later; DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant