Provide new feature flag context for devices #5226
Merged
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5226 +/- ##
=======================================
Coverage 43.70% 43.71%
=======================================
Files 1472 1472
Lines 67963 67970 +7
Branches 6161 6162 +1
=======================================
+ Hits 29703 29710 +7
Misses 36963 36963
Partials 1297 1297 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
addisonbeck
approved these changes
Jan 8, 2025
Comment on lines
+19
to
21
| private const string _contextKindDevice = "device"; | ||
| private const string _contextKindOrganization = "organization"; | ||
| private const string _contextKindServiceAccount = "service-account"; |
There was a problem hiding this comment.
At what point would we want to make this an enum/class?
There was a problem hiding this comment.
Well, I think I am done adding them and we can't invent any more, then another comes up. This is (probably) the last one! 😜
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Via Slack conversations.
📔 Objective
Adds a new context "kind" in LD for devices. When a device identifier is present, add the context so that targeting can be used against it -- this is needed for when a user has yet to be established so that context will not be available for anything other than the anonymous catch-all user.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes