Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15808]Show suspended org modals for orgs in 'unpaid' & 'canceled' status #5228

Conversation

cyprain-okeke
Copy link
Contributor

🎟️ Tracking

📔 Objective

https://bitwarden.atlassian.net/browse/PM-15808
display a modal (see figma)

there will be different versions of the modal depending on the user role and whether the organization is independent, MSP managed, or reseller managed.

For the independent org Owner

when subscription is in unpaid, keep the existing flow where they see the notice, and then they are taken to the payment method section of the admin console.

when the subscription is in canceled, then we show them the upgrade path UI.

we show them the current equivalent to their previous subscription. So, if they were on a Family, we show them Family, if they were on Enterprise 2019, we show them CURRENT Enterprise.

Uploading Screen Recording 2024-12-20 at 16.56.47.mov…

📸 Screenshots

Screen.Recording.2024-12-20.at.16.55.32.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner January 7, 2025 18:19
@cyprain-okeke cyprain-okeke merged commit eeb1be1 into main Jan 7, 2025
50 of 51 checks passed
@cyprain-okeke cyprain-okeke deleted the pm-15808-Show-suspended-org-modals-for-orgs-in-unpaid-and-canceled branch January 7, 2025 19:01
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 35.29412% with 22 lines in your changes missing coverage. Please review.

Project coverage is 43.69%. Comparing base (61a8726) to head (dfc653b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lling/Controllers/OrganizationBillingController.cs 9.09% 20 Missing ⚠️
...g/Models/Responses/OrganizationMetadataResponse.cs 50.00% 1 Missing ⚠️
...ices/Implementations/OrganizationBillingService.cs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5228      +/-   ##
==========================================
- Coverage   43.70%   43.69%   -0.01%     
==========================================
  Files        1472     1472              
  Lines       67963    67994      +31     
  Branches     6161     6166       +5     
==========================================
+ Hits        29703    29713      +10     
- Misses      36963    36984      +21     
  Partials     1297     1297              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Logo
Checkmarx One – Scan Summary & Details8930bec7-cf3f-483e-86a3-e7fc98805eef

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants