Skip to content
This repository has been archived by the owner on Nov 29, 2024. It is now read-only.

Fix invalid spaces encoding #158

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Conversation

tusbar
Copy link
Member

@tusbar tusbar commented Apr 3, 2020

MWS doesn’t support + spaces in either query string or POST body, but only %20.

Related: sindresorhus/got#1113

MWS doesn’t support + spaces, but only %20.
@tusbar tusbar added the bug Something isn't working label Apr 3, 2020
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #158 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   91.97%   92.00%   +0.03%     
==========================================
  Files         183      183              
  Lines        1233     1238       +5     
==========================================
+ Hits         1134     1139       +5     
  Misses         99       99              
Impacted Files Coverage Δ
lib/client/index.js 98.14% <100.00%> (+0.07%) ⬆️
lib/client/sign.js 100.00% <100.00%> (ø)
lib/client/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 233a2b9...e7f1587. Read the comment docs.

@tusbar tusbar merged commit fa272f4 into master Apr 3, 2020
@tusbar tusbar deleted the tusbar/fix-invalid-space-encoding branch April 3, 2020 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

1 participant