use geovista.common.VTK_CELL_IDS #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1299 +/- ##
=======================================
Coverage 91.63% 91.63%
=======================================
Files 59 59
Lines 2990 2990
=======================================
Hits 2740 2740
Misses 250 250 ☔ View full report in Codecov by Sentry. |
stephenworsley
added a commit
to stephenworsley/geovista
that referenced
this pull request
Jan 30, 2025
…matrix_correction * pp-mo/vector_frompoints: update to latest geovista-data version (bjlittle#1303) chore: (deps): bump github/codeql-action (bjlittle#1302) Fix method ref. Update registry for new vector example images fix from_cartesian polar cell unfold (bjlittle#1301) Fix vector examples text and make runnable as gallery examples. Update cache version (merged wrong?) Tidy vector example texts. use geovista.common.VTK_CELL_IDS (bjlittle#1299) docs: initial developer documentation guildlines (bjlittle#1298)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Minor tech debt tidy to use
geovista.common.VTK_CELL_IDSrather than the explicit string literal.