EnhancedPrecisionOp #431
Merged
EnhancedPrecisionOp #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For use as a single-file library, the following classes are added to the assembly: CommonBits, CommonBitsOp, CommonBitsRemover, and EnhancedPrecisionOp
Restored the test from JSTS version 0.17.0
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 63.96% 64.94% +0.98%
==========================================
Files 262 268 +6
Lines 13886 14259 +373
==========================================
+ Hits 8882 9261 +379
+ Misses 5004 4998 -6
Continue to review full report at Codecov.
|
Added tests for all the functions of the EnhancedPrecisionOp module: union, intersection, buffer, symDifference, difference
Test for CommonBitsOp
Tests for computes the Minimum Clearance of a Geometry.
Added a missing constant declaration (see the MinimumClearance test)
Added the MinimumClearance class to the build
Test for computes the minimum clearance of a geometry or set of geometries
Added the SimpleMinimumClearance class to the build
Extending the test coverage of the GeometryPrecisionReducer module
|
@iGureEV thanks this looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actively work with these classes, especially when using JSTS as a single-file library. And I would really appreciate adding these classes to the build library. If one previous test is not enough to accept a given pull request, then I can add additional ones.