Make dotenv-rails depend on rails 4 in production #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 yep, thanks! test failure seems unrelated to this, so I'll fix it in another PR. |
bkeepers
added a commit
that referenced
this pull request
Jun 5, 2015
Make dotenv-rails depend on rails 4 in production
|
fab :) |
sheax0r
pushed a commit
to sheax0r/dotenv
that referenced
this pull request
Sep 13, 2015
Make dotenv-rails depend on rails 4 in production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As dotenv-rails doesn't currently depend on rails 4 apart from in development, my gemspecs are pulling it in automatically in rails 3 apps. Obviously, I will fix my own bundle, but it seems that dotenv-rails should be linked to rails itself as a full dependency.