Moving away from deprecated django features #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django 3.0 removed the six vendored library in favour of the six package from pypi. https://docs.djangoproject.com/en/3.0/releases/3.0/#removed-private-python-2-compatibility-apis Changes model to use pypi's six and adds it to requirements.
ugettext_lazy was removed in Django 4.0 in favour of gettext_lazy. https://docs.djangoproject.com/en/dev/internals/deprecation/#deprecation-removed-in-4-0
annemacedo-tw
force-pushed
the
master
branch
from
4d66daf to
fa008ef
Compare
Reference: https://code.djangoproject.com/ticket/31967#comment:13 This allows us to go to 3.2 and beyond :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves away from some functions and libraries that were deprecated in Django. This includes:
sixnot being a vendored package anymoreugettext_lazybeing deprecated in favor ofgettext_lazyThis makes the library usable in newer versions of Django.
This patch also fixes the mixed types error, allowing us to go beyond Django 3.1 :)