Use short-circuit evaluation at And and Or operators. #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason of this PR that if we are in strict variables mode, then it is not good to check both sides of an And or Or expression.
Small example:
{% if context.isSpecial and context.special.value == "something" %}
It would not work because the right side is evaluated as well and the strict value check would throw an exception.
Current workaround is a nested if:
{% if context.isSpecial %}{% if context.special.value == "something" %}
That version is too verbose in my opinion.
It does not change the behavior if the strict variable check is turned off.
@bkiers what do you think?