-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The mute/unmute tab icons are missing since v132.0.0 #1011
Comments
Also the play button which is at same place. |
Got the same issue with 132.0 and Lepton v8.6.3 |
Same issue in Lepton's photon style. Same versions. |
On the photon-style branch removing this |
What part of Lepton code can be removed to completely avoid changing tab audio icons and have them appear instead of favicon as they do without Lepton? |
this doesnt do anything for me |
Ah, that was enough on my outdated local copy but on the upstream version you need to remove this property too. |
mute/unmute tab icons fix Line 22917 search: Line 23073 search: |
I confirm that these changes work. Thank you! However, now there’s an outline around the icon which also appears without the edit when the icon is transparent. Is there a way to remove it? Thanks again! |
add also you might want to change |
It work! Thank you very much! |
I've been busy lately so I'm a little late. mozilla/gecko-dev@fc47bb9#diff-e5d4b49c102df72478c0c4c9e6833c04ec79ffb16ef18a2f15d462e3e9994b64R438 |
I made a mistake by committing too hastily. |
I think, that this issue can be closed as completed. I tested these changes and the icon works as intended like before. If someone experiences this issue even after these commits, let me know to re-open it. |
The icon is now visible in proton-style after updating, but is incorrect in the same way holubv's screenshots showed. Looking at commit history it seems like the base fix is merged into the photon and proton branches, but the typo fix isn't? EDIT: Yeah, merging origin/master into proton-style in the local checkout now has the correct icons, so it looks like that should be enough. I'll keep that local merge in place for now and then undo that before my next update once it's updated here. |
Describe the bug
I noticed this issue after updating my Firefox to version 132.0.0.
Expected behavior
The mute/unmute tab icon should behave as in 131.0.0.
Screenshots
No response
OS
Windows 10
OS - Others
No response
Firefox Version
v132.0.0
Distribution
Theme
Theme - More Info
No response
user.js
setupuser.js
setupAdditional context
No response
The text was updated successfully, but these errors were encountered: