Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox 102 + Photon 5.2.1 = Black borders on tabs sides #429

Closed
3 of 13 tasks
virtualdj opened this issue Jul 2, 2022 · 2 comments
Closed
3 of 13 tasks

Firefox 102 + Photon 5.2.1 = Black borders on tabs sides #429

virtualdj opened this issue Jul 2, 2022 · 2 comments
Labels
Class::SideEffect Unexpected side effect, undefined behavior Component::Tabbar Tab or tabbar Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working Issue::Invalid This doesn't seem right

Comments

@virtualdj
Copy link

Describe the bug
After Firefox updated to 102 I had to upgrade the Photon style with the new one; however, a black thick border appears on the left and right side of each non-selected tab now. There's also an additional gray border on the left side of the + button that disappears when hovering on it.

Expected behavior
This issue is similar to the one that I'd written here (you can see from the screenshots there the difference), apart from the + border problem.

Screenshots
Black borders on the tabs side

Environment:

user.js setup

// No changes from the supplied file

Additional context
@virtualdj virtualdj added the Issue::Bug Something isn't working label Jul 2, 2022
black7375 added a commit that referenced this issue Jul 2, 2022
@black7375
Fix: Options - explicitly distribution settings #402 #429
217af2e
@black7375 black7375 added Env::Windows Issues on Windows10, Windows11, unknown windows Component::Tabbar Tab or tabbar Class::SideEffect Unexpected side effect, undefined behavior labels Jul 3, 2022
@black7375
Copy link
Owner

These symptoms are due to the conflict of setting.
To reduce the mistake of the user, we clearly distinguished true/false.

Try to using lastest photon-style setting.
https://github.com/black7375/Firefox-UI-Fix/blob/photon-style/user.js

@virtualdj
Copy link
Author

Try to using lastest photon-style setting.
https://github.com/black7375/Firefox-UI-Fix/blob/photon-style/user.js

Yep, that fixed both the 2 issues, thanks! With the new user.js:

New user.js

@black7375 black7375 added the Issue::Invalid This doesn't seem right label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Class::SideEffect Unexpected side effect, undefined behavior Component::Tabbar Tab or tabbar Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working Issue::Invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@virtualdj @black7375