Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon to "Private Container" link contextmenu & Tab contextmenu #774

Closed
surapunoyousei opened this issue Sep 20, 2023 · 3 comments
Closed
Labels
Browser::Fork Changes or bugs from Fork browsers Class::Icon Icon for panels, menus, libraries Component::Context-Menu Only for context menu Issue::Enhancement New feature or request

Comments

@surapunoyousei
Copy link
Contributor

surapunoyousei commented Sep 20, 2023

Is your feature request related to a problem?

This feature request relate to Floorp code.

The solution I'd like

Add these code to Floorp specific Lepton code.

#context_toggleToPrivateContainer {
    --menuitem-image: url("chrome://browser/skin/lepton/private-favicon.svg");      
}

#open_in_private_container {
    --menuitem-image: url("chrome://browser/skin/lepton/private-favicon.svg");
}

Screenshots or video

image

Alternatives I've considered

No response

Additional context

I will add this feature at 11.4.0

@surapunoyousei surapunoyousei added the Issue::Enhancement New feature or request label Sep 20, 2023
@surapunoyousei surapunoyousei changed the title Add "Private Container" link contextmenu & Tab contextmenu Add icon to "Private Container" link contextmenu & Tab contextmenu Sep 20, 2023
black7375 added a commit that referenced this issue Sep 20, 2023
@black7375
Copy link
Owner

I added a few things to work. I hope it will be useful.

@surapunoyousei
Copy link
Contributor Author

surapunoyousei commented Sep 21, 2023

Thanks!

I will include this file next version of Floorp.!

@black7375 black7375 added Class::Icon Icon for panels, menus, libraries Component::Context-Menu Only for context menu Browser::Fork Changes or bugs from Fork browsers labels Sep 23, 2023
@black7375
Copy link
Owner

I think this issue can be closed.
Please let me know if you have any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser::Fork Changes or bugs from Fork browsers Class::Icon Icon for panels, menus, libraries Component::Context-Menu Only for context menu Issue::Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants