Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[HOLD] add 'logSkyuxVersion' property #27

Closed
wants to merge 2 commits into from

Conversation

Blackbaud-TimPepper
Copy link
Contributor

Create property to allow users to ignore SkyUX version if none is needed, or if SkyUX does not exist.

@codecov-io
Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #27   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         162    164    +2     
  Branches       19     21    +2     
=====================================
+ Hits          162    164    +2
Impacted Files Coverage Δ
lib/utils.js 100% <ø> (ø) ⬆️
lib/settings.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82b3c75...05596ca. Read the comment docs.

@Blackbaud-TimPepper Blackbaud-TimPepper changed the title add 'logSkyuxVersion' property [HOLD] add 'logSkyuxVersion' property Oct 16, 2018
@Blackbaud-BobbyEarl
Copy link

As always, thanks for the hard work and PR @Blackbaud-TimPepper!

I'm going to close this PR in favor of #31 for two reason (which differs from what you and I originally talked about):

  • SKY UX 3 SPAs will no longer have a single "skyux2" entry in package.json since our components have been republished in a more modular fashion, and it's up to the SPA to dictate those versions.
  • Despite recording it previously, we never prioritized using the information in a supportal, so we're not losing any functionality for current SPAs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the add-logSkyuxVersion-prop branch May 26, 2020 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants