Publish error handling #45
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 177 184 +7
=====================================
+ Hits 177 184 +7
Continue to review full report at Codecov.
|
test/lib-publish.spec.js
Outdated
| throw error; | ||
| }); | ||
|
|
||
| try { |
There was a problem hiding this comment.
I think you want to call await expectAsync(...).toBeRejectedWith(...) here. The problem with the test as it's written is that if callPublish() doesn't throw an error, then no expects get called and the test will pass. See lib-deploy.spec.js for examples of how to use it. https://github.com/blackbaud/skyux-deploy/blob/master/test/lib-deploy.spec.js#L73
There was a problem hiding this comment.
Yup, I did a bad job of searching for toBeRejectedWith. I'll update.
test/lib-publish.spec.js
Outdated
| beforeEach(() => { | ||
| loggerMock = jasmine.createSpyObj('logger', ['info', 'error', 'bobby']); |
There was a problem hiding this comment.
What's bobby used for?
There was a problem hiding this comment.
To maintain my presence in this repo. J/K, I was debugging. I'll remove it.
No description provided.