Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging AENetworks fix from ytdl-org #290

Closed
wants to merge 2 commits into from
Closed

Merging AENetworks fix from ytdl-org #290

wants to merge 2 commits into from

Conversation

merval
Copy link

@merval merval commented Dec 25, 2020

Fixes #228

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This is a fix that was merged into ytdl-org to fix aenetworks. Merging here as well.

@pukkandan
Copy link
Contributor

@merval Is there any particular reason you made this into a separate PR when it is already part of #280? If you have added any new code, I will need to remove the corresponding part from my PR

@merval
Copy link
Author

merval commented Dec 28, 2020

No, that was me being a dumb ass and not realizing it was already in there. Sorry about that :-/ I'll close this out.

@merval merval closed this Dec 28, 2020
@merval merval deleted the merval/fix_aenetworks branch December 28, 2020 12:06
@pukkandan pukkandan mentioned this pull request Dec 29, 2020
siikamiika pushed a commit to siikamiika/yt-dlc that referenced this pull request Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Broken] aenetworks - Partial fix with PR
2 participants