Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in example introduction for the window adaptation part #366

Closed
oarriaga opened this issue Sep 30, 2022 · 1 comment · Fixed by #367
Closed

Typo in example introduction for the window adaptation part #366

oarriaga opened this issue Sep 30, 2022 · 1 comment · Fixed by #367
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@oarriaga
Copy link
Contributor

Hi hi! The original jupyter documentation for the introduction reused the state and kernel in cell 17 outputted from the window adaptation warmup in cell 16.

However, the current html documentation seems to use an entirely new kernel nuts.step with the previous state initial_state. If this is a typo I could send a quick PR changing the markdown file back to the original jupyter documentation form.

Thanks!

@rlouf
Copy link
Member

rlouf commented Oct 1, 2022

This is totally a typo!

@rlouf rlouf added the documentation Improvements or additions to documentation label Oct 1, 2022
@rlouf rlouf linked a pull request Oct 1, 2022 that will close this issue
@rlouf rlouf closed this as completed in #367 Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants