Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation typo for kernel and state input #367

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

oarriaga
Copy link
Contributor

@oarriaga oarriaga commented Oct 1, 2022

This PR addresses typo discussed here #366

@rlouf
Copy link
Member

rlouf commented Oct 1, 2022

Thanks! Did you run the notebook to make sure this works?

@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Merging #367 (e2f6f82) into main (bf15ed8) will not change coverage.
The diff coverage is n/a.

❗ Current head e2f6f82 differs from pull request most recent head be5d905. Consider uploading reports for the commit be5d905 to get more accurate results

@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files          45       45           
  Lines        2248     2248           
=======================================
  Hits         2018     2018           
  Misses        230      230           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@oarriaga
Copy link
Contributor Author

oarriaga commented Oct 1, 2022

No :O, I can do it, but how are you currently running the notebooks? Or do you mean to just run that notebook from the git past that I found, just to quickly verify that everything is working there even though it's not located explicitly in the present repo? I just don't know if you have a pipeline that transforms jupyter-notebooks located somewhere else into markdown files that I would need to explicitly verify. Just let me know :)!

@rlouf
Copy link
Member

rlouf commented Oct 1, 2022

Nevermind, I was doing something else in the documentation so I checked the calculations myself. Works great, thank you!.

@rlouf rlouf enabled auto-merge (rebase) October 1, 2022 21:29
@rlouf rlouf merged commit 19d3b93 into blackjax-devs:main Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in example introduction for the window adaptation part
2 participants