Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test folder structure analogous to the source code folder structure. #480

Closed
ciguaran opened this issue Jan 30, 2023 · 1 comment
Closed

Make test folder structure analogous to the source code folder structure. #480

ciguaran opened this issue Jan 30, 2023 · 1 comment
Labels
refactoring Change that adds no functionality but improves code quality

Comments

@ciguaran
Copy link
Contributor

Currently we have all tests in the same folder with no hierarchy. As it was previously discussed during Jan meeting, we want to move to having folder structure for the tests.

Q: Should we have one PR moving everything or start creating folders in different PRs?
@rlouf
Copy link
Member

rlouf commented Jan 30, 2023

Thanks for opening this issue. We can do all of it in a single PR.

@rlouf rlouf added the refactoring Change that adds no functionality but improves code quality label Jan 30, 2023
@ciguaran ciguaran mentioned this issue Feb 6, 2023
Merged
@albcab albcab closed this as completed Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Change that adds no functionality but improves code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rlouf @ciguaran @albcab