Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding folder structure to tests #483

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

ciguaran
Copy link
Contributor

@ciguaran ciguaran commented Feb 6, 2023

Solves issue #480 . I have moved entire folder files without splitting any of them into folder pieces, matching them to the modules in the source code.

A few important guidelines and requirements before we can merge your PR:

  • [Y] If I add a new sampler, there is an issue discussing it already;
  • [Y] We should be able to understand what the PR does from its title only;
  • [Y] There is a high-level description of the changes;
  • [Y] There are links to all the relevant issues, discussions and PRs;
  • [Y] The branch is rebased on the latest main commit;
  • [Y] Commit messages follow these guidelines;
  • [Y] The code respects the current naming conventions;
  • [Y] Docstrings follow the numpy style guide
  • [Y] pre-commit is installed and configured on your machine, and you ran it before opening the PR;
  • [Y] There are tests covering the changes;
  • [Y] The doc is up-to-date;
  • [Y] If I add a new sampler* I added/updated related examples

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #483 (94db89c) into main (f16fd05) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 94db89c differs from pull request most recent head e50e699. Consider uploading reports for the commit e50e699 to get more accurate results

@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
- Coverage   99.16%   99.16%   -0.01%     
==========================================
  Files          48       48              
  Lines        1915     1914       -1     
==========================================
- Hits         1899     1898       -1     
  Misses         16       16              
Impacted Files Coverage Δ
blackjax/util.py 100.00% <0.00%> (ø)
blackjax/optimizers/lbfgs.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rlouf rlouf force-pushed the ciguaran_tests_folder_structure branch from 94db89c to e50e699 Compare February 20, 2023 07:13
@rlouf rlouf enabled auto-merge (rebase) February 20, 2023 07:13
@rlouf
Copy link
Member

rlouf commented Feb 20, 2023

Looks good to me!

@rlouf rlouf merged commit c0d93a5 into blackjax-devs:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants