Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jax.tree_map in place of jax.tree_multimap #256

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

jakevdp
Copy link
Contributor

@jakevdp jakevdp commented Jul 20, 2022

The latter is deprecated in jax and will be removed in jax-ml/jax#11382

Note that in the last several JAX releases, tree_multimap is a direct alias of tree_map, so this substitution will not result in any change of behavior aside from silencing the deprecation warning (see https://github.com/google/jax/blob/5b576cb03e85f2e4d8d99f314cf5d87981ef5d42/jax/_src/tree_util.py#L198-L202).

The latter is deprecated in jax and will be removed in jax-ml/jax#11382
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #256 (eedf442) into main (4a4e0a4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          43       43           
  Lines        1757     1757           
=======================================
  Hits         1733     1733           
  Misses         24       24           
Impacted Files Coverage Δ
blackjax/sgmcmc/diffusion.py 100.00% <100.00%> (ø)

@junpenglao
Copy link
Member

Thank you!

@junpenglao junpenglao merged commit d440031 into blackjax-devs:main Jul 21, 2022
@jakevdp jakevdp deleted the tree-multimap branch July 21, 2022 05:25
junpenglao pushed a commit that referenced this pull request Mar 12, 2024
The latter is deprecated in jax and will be removed in jax-ml/jax#11382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants