S/acceptance probability/acceptance ratio #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #390 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 45 45
Lines 2184 2184
=======================================
Hits 1960 1960
Misses 224 224
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rlouf
force-pushed
the
s/acceptance_probability/acceptance_ratio
branch
2 times, most recently
from
655c227 to
df3081f
Compare
The term `acceptance_rate` applies more generally.
rlouf
added
enhancement
junpenglao
approved these changes
Oct 27, 2022
junpenglao
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Replace `acceptance_probability` with `acceptance_rate` The term `acceptance_rate` applies more generally. * Clean misc docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I replace the use of "acceptance_probability" with "acceptance_rate" which is more generally applicable, e.g. with NUTS. Closes #290