Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing TemperedSMC example #474

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Conversation

ciguaran
Copy link
Contributor

Thank you for opening a PR!

Tempered SMC notebook got broken after a recent PR that change the interface, fixing it.

A few important guidelines and requirements before we can merge your PR:

  • If I add a new sampler, there is an issue discussing it already;
  • We should be able to understand what the PR does from its title only;
  • There is a high-level description of the changes;
  • There are links to all the relevant issues, discussions and PRs;
  • The branch is rebased on the latest main commit;
  • Commit messages follow these guidelines;
  • The code respects the current naming conventions;
  • Docstrings follow the numpy style guide
  • pre-commit is installed and configured on your machine, and you ran it before opening the PR;
  • There are tests covering the changes;
  • The doc is up-to-date;
  • If I add a new sampler* I added/updated related examples

Consider opening a Draft PR if your work is still in progress but you would like some feedback from other contributors.

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #474 (ce78ae0) into main (e21fa82) will not change coverage.
The diff coverage is n/a.

❗ Current head ce78ae0 differs from pull request most recent head 0e1056d. Consider uploading reports for the commit 0e1056d to get more accurate results

@@           Coverage Diff           @@
##             main     #474   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          48       48           
  Lines        1914     1914           
=======================================
  Hits         1898     1898           
  Misses         16       16           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rlouf
Copy link
Member

rlouf commented Jan 19, 2023

LGTM, thank you for spotting and fixing this!

@rlouf rlouf merged commit 7df4d1b into blackjax-devs:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants