Drop support of Python 3.7 and install latest developments of optax to avoid failing tests #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albcab
force-pushed
the
optax-nightly
branch
3 times, most recently
from
5fa95c3 to
fff5a50
Compare
|
Additionally, JAX has dropped support of Python 3.7 from v0.4.1, optax has done the same in the latest developments. So, for the tests to pass in Python 3.7, I'd have to set an upper bound for the version of JAX (and optax) to install or not run tests in 3.7. I've chosen the latter because I imagine we want the latests features published on JAX. |
* drop support for Python 3.7 * tests and install test not only run in Python>=3.8
albcab
changed the title
Codecov Report
@@ Coverage Diff @@
## main #519 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 47 47
Lines 1947 1947
=======================================
Hits 1933 1933
Misses 14 14 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
junpenglao
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of JAX raises an error for the use of any deprecated version of
jax.Array. This creates errors in tests when importing optax (the latest release is from Nov 2022). In the latests developments of the library this is fixed, so we now install these latests developments instead of the latests release.We could install an earlier version of JAX, instead of the latest developments of optax.