Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change documentation background color" #527

Merged
merged 3 commits into from
May 4, 2023

Conversation

howsiyu
Copy link
Contributor

@howsiyu howsiyu commented Apr 20, 2023

This reverts commit 6963ecf.

With the background-color added in custom.css the documentation page in dark mode is displayed like this.
Screenshot 2023-04-20 at 07-34-35 A Quick Introduction to Blackjax

@junpenglao junpenglao assigned junpenglao and rlouf and unassigned junpenglao Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #527 (940b1db) into main (39760ef) will not change coverage.
The diff coverage is n/a.

❗ Current head 940b1db differs from pull request most recent head ecaf0b5. Consider uploading reports for the commit ecaf0b5 to get more accurate results

@@           Coverage Diff           @@
##             main     #527   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files          47       47           
  Lines        1948     1948           
=======================================
  Hits         1934     1934           
  Misses         14       14           

@howsiyu
Copy link
Contributor Author

howsiyu commented Apr 20, 2023

I am guessing what was intended is something like

html[data-theme=light] {
    --pst-color-background: #fefefa;
    --pst-color-surface: #f7f7f3;
}

@junpenglao junpenglao merged commit 95a92fd into blackjax-devs:main May 4, 2023
@howsiyu howsiyu deleted the revert-doc-background-color branch May 4, 2023 10:45
junpenglao added a commit that referenced this pull request Mar 12, 2024
This reverts commit 6963ecf.

Co-authored-by: Junpeng Lao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants