Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update howto_use_tfp.md #553

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Update howto_use_tfp.md #553

merged 2 commits into from
Jun 21, 2023

Conversation

junpenglao
Copy link
Member

@junpenglao junpenglao commented Jun 20, 2023

Simplify model building in TFP

Thank you for opening a PR!

A few important guidelines and requirements before we can merge your PR:

  • If I add a new sampler, there is an issue discussing it already;
  • We should be able to understand what the PR does from its title only;
  • There is a high-level description of the changes;
  • There are links to all the relevant issues, discussions and PRs;
  • The branch is rebased on the latest main commit;
  • Commit messages follow these guidelines;
  • The code respects the current naming conventions;
  • Docstrings follow the numpy style guide
  • pre-commit is installed and configured on your machine, and you ran it before opening the PR;
  • There are tests covering the changes;
  • The doc is up-to-date;
  • If I add a new sampler* I added/updated related examples

Consider opening a Draft PR if your work is still in progress but you would like some feedback from other contributors.

Simplify model building in TFP
@junpenglao junpenglao enabled auto-merge (squash) June 20, 2023 11:31
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #553 (d3113a3) into main (fd2cae8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #553   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files          49       49           
  Lines        2099     2099           
=======================================
  Hits         2081     2081           
  Misses         18       18           

@junpenglao junpenglao disabled auto-merge June 21, 2023 05:02
@junpenglao junpenglao merged commit b063491 into main Jun 21, 2023
@junpenglao junpenglao deleted the junpenglao-patch-1 branch June 21, 2023 05:03
junpenglao added a commit that referenced this pull request Mar 12, 2024
* Update howto_use_tfp.md

Simplify model building in TFP

* clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant