Bump to Py3.9 #554
Merged
Bump to Py3.9 #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #554 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 49 49
Lines 2099 2099
=======================================
Hits 2081 2081
Misses 18 18
|
rlouf
reviewed
Jun 21, 2023
| @@ -68,7 +68,7 @@ class MassMatrixAdaptationState(NamedTuple): | |||
|
|
|||
| def mass_matrix_adaptation( | |||
| is_diagonal_matrix: bool = True, | |||
| ) -> Tuple[Callable, Callable, Callable]: | |||
| ) -> tuple[Callable, Callable, Callable]: | |||
There was a problem hiding this comment.
Nope, but from py3.9 onward we can "use built-in collection types such as list and dict as generic types instead of importing the corresponding capitalized types (e.g. List or Dict) from typing."
https://docs.python.org/3/whatsnew/3.9.html#type-hinting-generics-in-standard-collections
albcab
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.