Adjusts for the fact that IRMH proposal might not be symmetric #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #581 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 49 49
Lines 2117 2117
=======================================
Hits 2099 2099
Misses 18 18
|
|
Thanks, could you add a small test? |
junpenglao
reviewed
Oct 31, 2023
| """ | ||
|
|
||
| def proposal_generator(rng_key: PRNGKey, position: ArrayTree): | ||
| del position |
There was a problem hiding this comment.
done, just out of curiosity why is that del needed?
There was a problem hiding this comment.
It's not needed, mostly it is styling to signify the input arg is not needed.
Added the smallest test that only tests the behavior within this kernel, so as to avoid retesting MH acceptance rule, which is already tested in another place. |
junpenglao
approved these changes
Oct 31, 2023
junpenglao
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Adjusting for the fact that the IRMH proposal might not be symmetric * Fixing type annotation * Adding proposal_logdensity_fn to the interface exposed to users, with default parameter * Applying pre-commit to all files * Adding minimal test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a PR!
Adds proposal_logdensity_fn as parameter, so as to modify MH acceptance rule to accommodate for non-symmetry of the proposal distribution.
A few important guidelines and requirements before we can merge your PR:
maincommit;pre-commitis installed and configured on your machine, and you ran it before opening the PR;I haven't added new tests since this is just calling build_rmh from within a factory (IRMH is indeed a factory) and the functionality is already well tested.
Consider opening a Draft PR if your work is still in progress but you would like some feedback from other contributors.