Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MCLMC sampler #586
Add MCLMC sampler #586
Changes from 59 commits
fbe7f75
3a23242
86b3a90
e82550f
f0e1bec
4d7dc57
82b8466
a4d403b
a67ecb7
3dd4f74
5d8061d
5428f2c
59ecc8a
2bf639e
172fee0
b710e62
3cc52fd
57d5c3b
7e70d78
1343463
e53a877
05517b6
d84a23d
de1e5cf
263ab3a
777213d
e75274a
8a89f13
49b3bec
81999f9
8ab01f2
6266bc4
ca984e7
59ffb21
8f9214f
b2e3b8e
2fb2293
59e4424
6684413
4284092
4a514dd
ef1f62d
af43521
0dd419d
0c8330e
e6fa2bb
40fc61c
6ea5320
c83dc1a
c8b43be
8894248
9865145
68464bc
0c61412
a66af60
be07631
71d934b
a170d0b
8cfb75f
b42e77e
2b323ce
9a41cdf
cdbb4f6
947d717
e9ab7b4
72d70c6
c121beb
fe99163
c456efe
d0a008a
d692498
3e8d8ea
eda029a
a45f58f
2a21c56
67f0de9
3f55f5f
666c540
c1615f5
ae1bf30
3c2dbad
c396aa1
0902a1c
2e3c80b
604b5a9
50b1c95
fecd82b
50a8243
a20a681
75e71de
70f1dd5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of copying large proportion of code, you should refactor the origin function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, will definitely do that.
Check warning on line 277 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L277
Check warning on line 284 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L283-L284
Check warning on line 286 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L286
Check warning on line 293 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L288-L293
Check warning on line 297 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L296-L297
Check warning on line 302 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L302
Check warning on line 304 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L304
Check warning on line 313 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L312-L313
Check warning on line 316 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L316
Check warning on line 326 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L324-L326
Check warning on line 330 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L328-L330
Check warning on line 336 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L332-L336
Check warning on line 338 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L338
Check warning on line 343 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L341-L343
Check warning on line 346 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L345-L346
Check warning on line 352 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L349-L352
Check warning on line 355 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L354-L355
Check warning on line 360 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L359-L360
Check warning on line 364 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L363-L364
Check warning on line 371 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L370-L371
Check warning on line 374 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L373-L374
Check warning on line 381 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L380-L381
Check warning on line 391 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L391
Check warning on line 393 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L393
Check warning on line 396 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L396
Check warning on line 400 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L400
Check warning on line 404 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L404
Check warning on line 406 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L406
Check warning on line 411 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L408-L411
Check warning on line 414 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L414
Check warning on line 419 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L418-L419
Check warning on line 421 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L421
Check warning on line 424 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L424
Check warning on line 427 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L427
Check warning on line 430 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L430
Check warning on line 432 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L432
Check warning on line 438 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L438
Check warning on line 440 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L440
Check warning on line 446 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L443-L446
Check warning on line 449 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L449
Check warning on line 452 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L452
Check warning on line 454 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L454
Check warning on line 457 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L457
Check warning on line 460 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L460
Check warning on line 465 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L465
Check warning on line 472 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L469-L472
Check warning on line 474 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L474
Check warning on line 477 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L476-L477
Check warning on line 487 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L487
Check warning on line 491 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L491
Check warning on line 497 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L495-L497
Check warning on line 502 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L501-L502
Check warning on line 513 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L512-L513
Check warning on line 515 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L515
Check warning on line 519 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L519
Check warning on line 521 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L521
Check warning on line 529 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L529
Check warning on line 542 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L542
Check warning on line 545 in blackjax/adaptation/step_size.py
Codecov / codecov/patch
blackjax/adaptation/step_size.py#L545
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Splitting the changes here into #589
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean remove this change (since it was added because you were copying the changes from the integrator PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to remove this line.