Remove transform from MCLMC #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #623 +/- ##
==========================================
+ Coverage 99.22% 99.26% +0.03%
==========================================
Files 57 57
Lines 2581 2582 +1
==========================================
+ Hits 2561 2563 +2
+ Misses 20 19 -1 ☔ View full report in Codecov by Sentry. |
junpenglao
pushed a commit
that referenced
this pull request
Mar 12, 2024
* ADD TRANSFORM * ADD TRANSFORM * ADD DOCSTRING AND TEST * REMOVE TRANSFORMED_X FROM INFO * REMOVE TRANSFORMED_X FROM INFO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MCLMC had previously carried around
transformed_positionin its info, which is both unnecessary and at odds with the design of blackjax.Now removed, and tests and tuning appropriately changed.
Close #615