RENAME NONEUCLIDEAN TO ISOKINETIC #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junpenglao
approved these changes
Dec 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 59 59
Lines 2738 2738
=======================================
Hits 2708 2708
Misses 30 30 ☔ View full report in Codecov by Sentry. |
junpenglao
pushed a commit
that referenced
this pull request
Mar 12, 2024
* RENAME NONEUCLIDEAN TO ISOKINETIC * REMOVE ACCIDENTALLY ADDED FILE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I understand, there isn't really a sense in which the integrator is noneuclidean. "Isokinetic" was coined by https://pubs.aip.org/aip/jcp/article-abstract/118/6/2510/438540/Algorithms-and-novel-applications-based-on-the, which we discovered is the first paper proposing the form of this integrator (but without the stochasticity introduced in the MCHMC papers)