-
Notifications
You must be signed in to change notification settings - Fork 41
Https redirection with one server #17
Comments
I will check this issue! |
* origin/2.2: Fixing #17 missing configuration for port-80-redirect. New readme and recomendations for versions.
Fixed in version 2.2 and latest. |
* origin/2.2: Fixing #17 missing configuration for port-80-redirect. New readme and recomendations for versions.
The generated config for port redirection had been directly deleted by the next operation. Must have been a mistake when making version 2.2 where i moved the generated config to folder /etc/nginx |
Hey looks like i'm still getting some strangeness on my side with latest tag. Looking into it some more.. suspect a bug in https://github.com/blacklabelops/nginx/blob/master/imagescripts/port_redirect.sh - may need to reopen |
I will recheck. |
Hello Hash, I rechecked the development tag and the issue seems fixed. This fix won't be available on the latest tag until version 2.2 is released. |
Hey thanks for the recheck. Could you just clarify what is happening in the port redirect script at https://github.com/blacklabelops/nginx/blob/master/imagescripts/port_redirect.sh#L16-L18 please? It seems to me that if the server name is not assigned then there is no effective redirect. |
That's the loop-end check for enumerated variables. You never know how many envs of the kind
Maybe |
Ok I am not using a |
yes |
I'm not 100% certain on the behaviour but it seems to me like the
NGINX_REDIRECT_PORT80
setting is not effective with a single server definition e.g.:The text was updated successfully, but these errors were encountered: