-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an 'update' entity to report new versions of the Frigate backend #237
Add an 'update' entity to report new versions of the Frigate backend #237
Conversation
@NickM-27 I'll leave this alone until the build passes -- just use the 'Request review' whenever you're ready. |
Haha yeah it'll be a WIP, I may have some questions once I get further, but need to wait until the frigate PR is finalized since I've had some comments. |
According to the update entity docs it can support showing the changelog, but it would need to pull it down separately and also has a max length 255 characters which is much shorter than frigate full releases typically are, so probably best to leave that out. |
@dermotduffy It seems to be complaining that it can't find the update entity, I figured that the tests would automatically use the latest HA version? Edit: I updated the reqs to require the newest HA |
@dermotduffy I may need some help with these tests, not sure what changed in HA that makes media_source miss so many |
@dermotduffy any thoughts on this? not sure if these tests are broken or if there is full functionality broken in HASS 2022.4? |
🤞 once #242 gets merged, I can redo this and it will be passing, not too sure though with the changes to HA calls |
As discussed on discord, try again after rebasing to #243 (and install the new requirements). You may have more luck. |
0d1026e
to
01f410a
Compare
Okay just realized my error here being that I can't access the object attributes from the entity state |
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 11 +1
Lines 1325 1373 +48
=========================================
+ Hits 1325 1373 +48
Continue to review full report at Codecov.
|
@dermotduffy should be good for review |
…gration into #235_update_entity
…gration into #235_update_entity
Cool, that seems to have done it |
Thanks @NickM-27 ! |
I think I would prevent the creation of this update entity in case Frigate is known to be installed via the addon, otherwise there would be two update entities for the same thing, basically (as Supervisor already provides it). |
Implements #235
Based off of WLED implementation as that is one of the few available for reference. Pre-requisite frigate PR is blakeblackshear/frigate#3038