-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favorite events delete button warning #3225
Favorite events delete button warning #3225
Conversation
that feature should be linked to calculation/estimation of storage space (=recording-time) left ... |
I'm not sure what you mean? This goes along with the favorites feature which in the beta already allows saving a clip / event from being deleted. I'm not sure how this is related to that FR. It is similar in that it deals with saving events but the implementation is entirely different. And this specific PR is only having to do with the UI. I may be missing some context |
…rigate into favorite-delete-protection
ok, would be nice to see somehwere how much recording-time is left after storage or deleting. but maybe that unrelated here and must be out somewhere else.... |
@ozett I see what you mean. Yeah that wouldn't be related to this but could be something for the future. Maybe add your comments to the issue you linked. |
As mentioned in #3221 (comment)
Would be good to provide a deletion dialog for favorite / saved events in case of a misclick. This changes nothing for events that are not favorited.
Screenshot for reference when clicking delete on a favorited event: