Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorite events delete button warning #3225

Conversation

NickM-27
Copy link
Collaborator

As mentioned in #3221 (comment)

Would be good to provide a deletion dialog for favorite / saved events in case of a misclick. This changes nothing for events that are not favorited.

Screenshot for reference when clicking delete on a favorited event:

Screen Shot 2022-05-18 at 9 05 43 AM

@ozett
Copy link

ozett commented May 20, 2022

that feature should be linked to calculation/estimation of storage space (=recording-time) left ...
(estimate how long recordingtime will remain, when blocking and delete-protect a clip of specific length)
see: FR #994 (comment)

@NickM-27
Copy link
Collaborator Author

NickM-27 commented May 20, 2022

that feature should be linked to calculation/estimation of storage space (=recording-time) left ...

(estimate how long recordingtime will remain, when blocking and delete-protect a clip of specific length)

see: FR #994 (comment)

I'm not sure what you mean? This goes along with the favorites feature which in the beta already allows saving a clip / event from being deleted.

I'm not sure how this is related to that FR. It is similar in that it deals with saving events but the implementation is entirely different. And this specific PR is only having to do with the UI. I may be missing some context

@NickM-27 NickM-27 changed the title Favorite events delete protection Favorite events delete button warning May 20, 2022
@ozett
Copy link

ozett commented May 20, 2022

ok,
permanent storage of some clips will change remaining disk-space.
deleting of clips also.

would be nice to see somehwere how much recording-time is left after storage or deleting.
i know, thats highly dynamic, but there could AI along with some estimation on historical data...

but maybe that unrelated here and must be out somewhere else....
i dreamed of a pop-up on permanent storage or on deleting clips, thats says:
" you have estimated 3 hrs recording time left" or " you gained 3 days recording time"

@NickM-27
Copy link
Collaborator Author

@ozett I see what you mean. Yeah that wouldn't be related to this but could be something for the future. Maybe add your comments to the issue you linked.

@blakeblackshear blakeblackshear merged commit ca69324 into blakeblackshear:release-0.11.0 May 26, 2022
@NickM-27 NickM-27 deleted the favorite-delete-protection branch May 26, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants