[breaking] Update Ember to v5.12.0 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated using `ember-cli-update` to update all of the blueprints and then added `@ember/string` to the dependencies as this is a real package now. Biggest weirdness was that ember-cli-update was configured to use `yarn` but this project is using npm.
Prettier is in place now, some changes. Also replaced assert.equal with it's now, required, strictEqual.
These are no longer part of the blueprint, and aren't needed.
This allows @ember/string to be importable in apps consuming this addon.
These are provided as part of the blueprint now.
|
Wow, this package is a blast from the past! Thanks for taking the time to submit this PR. I haven't used Ember in many years, but this upgrade seems straightforward to me. As a disclaimer, I just reviewed the code and haven't validated otherwise. I'll release this as v4.0.0. |
|
Thanks for the quick merge and release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated using
ember-cli-updateto update all of the blueprints, fixed linting issues, and fixed the@ember/stringimport.Labeled it breaking as it drops support for Node < 18.x.
The impetus of this is addressing an issue when our app updated
@ember/string.Let me know if you're still ok maintaining this addon @blimmer. It seems pretty stable and I'm happy to do a PR every couple of years to align the blueprints.