Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File provider is leaking storage. #1619

Closed
yury opened this issue Nov 2, 2022 · 3 comments
Closed

File provider is leaking storage. #1619

yury opened this issue Nov 2, 2022 · 3 comments
Assignees
@carloscabanero

Comments

@yury
Copy link
Collaborator

yury commented Nov 2, 2022

Even if file is deleted after download, space used by Blink is not decreased.

Also If user deleted provider we should cleanup space.
@carloscabanero carloscabanero self-assigned this Nov 2, 2022
@aikinai
Copy link

aikinai commented Nov 15, 2022

I guess I have the same issue? Blink was using over 8GB of storage. I deleted the app and installed from scratch and it's gone for now.

@carloscabanero
Copy link
Member

Hey, sorry about that. We forgot to link to a workaround for this:

#1601 (comment)

@carloscabanero
Copy link
Member

We added a way to clean up the storage inside Blink (just remove the location inside hosts).

This will be fixed as part of #1717. Closing here

yury pushed a commit that referenced this issue Apr 7, 2023
File Provider leaking storage when deleting elements
0e87f79 
- Delete the element in local cache when it gets deleted in the remote.
- If there is an error on startProvidingItem, delete the local element to avoid
a mismatch

Fixes #1619
carloscabanero pushed a commit that referenced this issue May 12, 2023
File Provider leaking storage when deleting elements
45738a8 
- Delete the element in local cache when it gets deleted in the remote.
- If there is an error on startProvidingItem, delete the local element to avoid
a mismatch

Fixes #1619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carloscabanero carloscabanero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yury @carloscabanero @aikinai