clang-tidy currently breaks stuff, needs to be fixed

blipper · Aug 2, 2018 · 257b594 · 257b594
1 parent cdc1f15
commit 257b594
Show file tree

Hide file tree

Showing 14 changed files with 61 additions and 369 deletions.
diff --git a/.clang-format b/.clang-format
@@ -1 +1 @@
-BasedOnStyle: LLVM
+BasedOnStyle: LLVM
diff --git a/.clang-tidy b/.clang-tidy
@@ -1,4 +1,4 @@
-Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming'
+Checks: '-*,modernize-use-override,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming'
 CheckOptions:
   - key:             readability-identifier-naming.ClassCase
     value:           CamelCase
@@ -13,4 +13,4 @@ CheckOptions:
   - key:             readability-identifier-naming.UnionCase
     value:           CamelCase
   - key:             readability-identifier-naming.VariableCase
-    value:           CamelCase
+    value:           CamelCase
diff --git a/include/phasar/PhasarLLVM/IfdsIde/Problems/IFDSUninitializedVariables.h b/include/phasar/PhasarLLVM/IfdsIde/Problems/IFDSUninitializedVariables.h
@@ -33,7 +33,6 @@ class IFDSUnitializedVariables
     : public DefaultIFDSTabulationProblem<
           const llvm::Instruction *, const llvm::Value *,
           const llvm::Function *, LLVMBasedICFG &> {
-
 public:
   typedef const llvm::Value *d_t;
   typedef const llvm::Instruction *n_t;

diff --git a/include/phasar/PhasarLLVM/Mono/Solver/InterMonotoneGeneralizedSolver.h b/include/phasar/PhasarLLVM/Mono/Solver/InterMonotoneGeneralizedSolver.h
@@ -262,7 +262,6 @@ class InterMonotoneGeneralizedSolver {
       auto dst_range = Analysis[dst].equal_range(dst_context);
       for (auto &analysis_dst_it = dst_range.first;
            analysis_dst_it != dst_range.second; ++analysis_dst_it) {
-
         // flowfactsstabilized = true <-> Same std::set & already visited once
         bool flowfactsstabilized =
             dst_context_already_exist

diff --git a/include/phasar/PhasarLLVM/Pointer/TypeGraph.h b/include/phasar/PhasarLLVM/Pointer/TypeGraph.h
diff --git a/include/phasar/Utils/MultiIndexTable.h b/include/phasar/Utils/MultiIndexTable.h
@@ -32,7 +32,6 @@ struct ORDERED_ROW_COL_KEY_TAG {};
 struct HASHED_ROW_COL_KEY_TAG {};
 
 template <typename R, typename C, typename V> struct MultiIndexTable {
-
   struct TableData {
     R rowkey;
     C columnkey;

diff --git a/lib/DB/DBConn.cpp b/lib/DB/DBConn.cpp
@@ -859,7 +859,6 @@ void operator>>(DBConn &db, PointsToGraph &PTG) {
 void DBConn::storeLLVMBasedICFG(const LLVMBasedICFG &ICFG,
                                 const string &ProjectName, bool use_hs) {
   try {
-
   } catch (sql::SQLException &e) {
     SQL_STD_ERROR_HANDLING;
   }
@@ -868,7 +867,6 @@ void DBConn::storeLLVMBasedICFG(const LLVMBasedICFG &ICFG,
 LLVMBasedICFG DBConn::loadLLVMBasedICFGfromModule(const string &ModuleName,
                                                   bool use_hs) {
   try {
-
   } catch (sql::SQLException &e) {
     SQL_STD_ERROR_HANDLING;
   }
@@ -881,7 +879,6 @@ LLVMBasedICFG
 DBConn::loadLLVMBasedICFGfromModules(initializer_list<string> ModuleNames,
                                      bool use_hs) {
   try {
-
   } catch (sql::SQLException &e) {
     SQL_STD_ERROR_HANDLING;
   }
@@ -893,7 +890,6 @@ DBConn::loadLLVMBasedICFGfromModules(initializer_list<string> ModuleNames,
 LLVMBasedICFG DBConn::loadLLVMBasedICFGfromProject(const string &ProjectName,
                                                    bool use_hs) {
   try {
-
   } catch (sql::SQLException &e) {
     SQL_STD_ERROR_HANDLING;
   }
@@ -905,7 +901,6 @@ LLVMBasedICFG DBConn::loadLLVMBasedICFGfromProject(const string &ProjectName,
 void DBConn::storePointsToGraph(const PointsToGraph &PTG,
                                 const string &ProjectName, bool use_hs) {
   try {
-
   } catch (sql::SQLException &e) {
     SQL_STD_ERROR_HANDLING;
   }
@@ -914,7 +909,6 @@ void DBConn::storePointsToGraph(const PointsToGraph &PTG,
 PointsToGraph DBConn::loadPointsToGraphFromFunction(const string &FunctionName,
                                                     bool use_hs) {
   try {
-
   } catch (sql::SQLException &e) {
     SQL_STD_ERROR_HANDLING;
   }
@@ -1097,7 +1091,6 @@ LLVMTypeHierarchy
 DBConn::loadLLVMTypeHierarchyFromProject(const string &ProjectName,
                                          bool use_hs) {
   try {
-
   } catch (sql::SQLException &e) {
     SQL_STD_ERROR_HANDLING;
   }
@@ -1106,7 +1099,6 @@ DBConn::loadLLVMTypeHierarchyFromProject(const string &ProjectName,
 
 void DBConn::storeIDESummary(const IDESummary &S) {
   try {
-
   } catch (sql::SQLException &e) {
     SQL_STD_ERROR_HANDLING;
   }
@@ -1115,7 +1107,6 @@ void DBConn::storeIDESummary(const IDESummary &S) {
 IDESummary DBConn::loadIDESummary(const string &FunctionName,
                                   const string &AnalysisName) {
   try {
-
   } catch (sql::SQLException &e) {
     SQL_STD_ERROR_HANDLING;
   }

diff --git a/lib/PhasarLLVM/Plugins/IFDSSimpleTaintAnalysis.cxx b/lib/PhasarLLVM/Plugins/IFDSSimpleTaintAnalysis.cxx
@@ -80,7 +80,6 @@ IFDSSimpleTaintAnalysis::getCallFlowFunction(const llvm::Instruction *callStmt,
     if (destMthd->getName().str() == "taint") {
       return make_shared<Gen<const llvm::Value *>>(Call, zeroValue());
     } else if (destMthd->getName().str() == "leak") {
-
     } else {
     }
   }

diff --git a/lib/PhasarLLVM/Pointer/LLVMTypeHierarchy.cpp b/lib/PhasarLLVM/Pointer/LLVMTypeHierarchy.cpp
@@ -65,7 +65,6 @@ LLVMTypeHierarchy::LLVMTypeHierarchy(ProjectIRDB &IRDB) {
   for (auto vertex : type_vertex_map) {
     tie(ei, ei_end) = boost::out_edges(vertex.second, tc);
     for (; ei != ei_end; ++ei) {
-
       auto source = boost::source(*ei, tc);
       auto target = boost::target(*ei, tc);
       g[vertex.second].reachableTypes.insert(g[target].name);

diff --git a/lib/PhasarLLVM/Pointer/TypeGraph.cpp b/lib/PhasarLLVM/Pointer/TypeGraph.cpp