-
-
Notifications
You must be signed in to change notification settings - Fork 801
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
e3522d6
commit 022392c
Showing
8 changed files
with
430 additions
and
311 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
"@blitzjs/next": patch | ||
"blitz": patch | ||
"@blitzjs/generator": patch | ||
--- | ||
|
||
- Updates `ts-log` peer dependency to `4.9.0` | ||
- Removes `javascript` from `blitz new` menu | ||
- Hot Fix the `Update Schema` when using blitz generator |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,7 +111,7 @@ jobs: | |
echo "folders=$folders" >> $GITHUB_OUTPUT | ||
Integration-Tests: | ||
name: "Integration Test: ${{matrix.folder}} @ ${{ matrix.os }} " | ||
name: "Integration Test: ${{matrix.folder}} @ ${{ matrix.os }}" | ||
needs: [find-integration-tests] | ||
strategy: | ||
matrix: | ||
|
@@ -124,32 +124,39 @@ jobs: | |
steps: | ||
- run: echo ${{matrix.folder}} | ||
- name: Checkout | ||
if: matrix.folder != 'next-13-app-dir' || matrix.os != 'windows-latest' | ||
uses: actions/checkout@v3 | ||
|
||
- name: Setup PNPM | ||
if: matrix.folder != 'next-13-app-dir' || matrix.os != 'windows-latest' | ||
uses: pnpm/[email protected] | ||
with: | ||
version: 8.6.5 | ||
|
||
- name: Setup node@18 | ||
if: matrix.folder != 'next-13-app-dir' || matrix.os != 'windows-latest' | ||
uses: actions/setup-node@v2 | ||
with: | ||
node-version: 18 | ||
cache: "pnpm" | ||
|
||
- name: Install dependencies | ||
if: matrix.folder != 'next-13-app-dir' || matrix.os != 'windows-latest' | ||
run: pnpm install --frozen-lockfile | ||
shell: bash | ||
|
||
- name: Install playwright | ||
if: matrix.folder != 'next-13-app-dir' || matrix.os != 'windows-latest' | ||
run: | | ||
pnpx [email protected] install --with-deps | ||
shell: bash | ||
|
||
- name: Build | ||
if: matrix.folder != 'next-13-app-dir' || matrix.os != 'windows-latest' | ||
run: pnpm build | ||
shell: bash | ||
|
||
- name: Test Packages | ||
if: matrix.folder != 'next-13-app-dir' || matrix.os != 'windows-latest' | ||
run: pnpm test -- --filter=./integration-tests/${{matrix.folder}} | ||
shell: bash |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,14 +12,13 @@ import {codegenTasks} from "../utils/codegen-tasks" | |
|
||
type NotUndefined<T> = T extends undefined ? never : T | ||
const forms: Record<NotUndefined<AppGeneratorOptions["form"]>, string> = { | ||
finalform: "React Final Form (recommended)", | ||
formik: "Formik (recommended)", | ||
This comment has been minimized.
Sorry, something went wrong. |
||
finalform: "React Final Form", | ||
hookform: "React Hook Form", | ||
formik: "Formik", | ||
} | ||
|
||
const language = { | ||
typescript: "TypeScript", | ||
javascript: "JavaScript", | ||
This comment has been minimized.
Sorry, something went wrong.
Kosai106
Contributor
|
||
} | ||
|
||
type TLanguage = keyof typeof language | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Changing the recommended option here doesn't seem like it's "fixing" anything? What was the motivation behind this change, I'm curious.
Not to mention that the docs still make it sound like
React Final Form
is the preferred way to go: