-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade tslog
dependency from 4.8.2
to 4.9.0
#4180
Conversation
"Resolves" the following issue: fullstack-build/tslog#227
This value doesn't exist in 4.7.4, and is unused.
🦋 Changeset detectedLatest commit: 1fedfa9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
LGTM!
Is this something we can get merged soon? Its becoming a fairly common issue in our codebase |
Hey @dbrxnds sorry about the wait, but since the CI is broken, I do not feel comfortable merging the PR. I will have more time tomorrow to fix the CI and then we can merge this and a few more and possibly a release. |
No worries, I understand. Appreciate your time! @siddhsuresh |
Hi @siddhsuresh, It seems Do you want me to update this PR to upgrade to that version instead of downgrading? Or open a new PR entirely? |
Hey @justinsmid, yeah lets upgrade to |
tslog
dependency from 4.8.2
to 4.7.4
tslog
dependency from 4.8.2
to 4.9.0
Added @justinsmid contributions for doc and code |
Closes #4179
What are the changes and their implications?
Downgrades
tslog
to a version where the issue described in fullstack-build/tslog#227 does not occur.Bug Checklist
pnpm changeset
in the root directory)Feature Checklist
pnpm changeset
in the root directory)main
branch)