Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tslog dependency from 4.8.2 to 4.9.0 #4180

Merged
merged 8 commits into from
Aug 14, 2023

Conversation

justinsmid
Copy link
Contributor

Closes #4179

What are the changes and their implications?

Downgrades tslog to a version where the issue described in fullstack-build/tslog#227 does not occur.

Bug Checklist

  • Changeset added (run pnpm changeset in the root directory)
  • Integration test added (see test docs if needed)

Feature Checklist

This value doesn't exist in 4.7.4, and is unused.
@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

🦋 Changeset detected

Latest commit: 1fedfa9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
blitz Patch
@blitzjs/next Patch
@blitzjs/generator Patch
next-blitz-auth Patch
@blitzjs/auth Patch
@blitzjs/rpc Patch
@blitzjs/codemod Patch
@blitzjs/config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@siddhsuresh siddhsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

LGTM!

@dbrxnds
Copy link
Contributor

dbrxnds commented Aug 2, 2023

Is this something we can get merged soon? Its becoming a fairly common issue in our codebase

@siddhsuresh
Copy link
Member

Hey @dbrxnds sorry about the wait, but since the CI is broken, I do not feel comfortable merging the PR. I will have more time tomorrow to fix the CI and then we can merge this and a few more and possibly a release.

@dbrxnds
Copy link
Contributor

dbrxnds commented Aug 2, 2023

No worries, I understand. Appreciate your time! @siddhsuresh

@justinsmid
Copy link
Contributor Author

justinsmid commented Aug 8, 2023

Hi @siddhsuresh,

It seems tslog fixed the issue in 4.9.0: fullstack-build/tslog#227 (comment)
I checked by manually overriding tslog's version and it does indeed resolve my issue.

Do you want me to update this PR to upgrade to that version instead of downgrading? Or open a new PR entirely?

@siddhsuresh
Copy link
Member

Hi @siddhsuresh,

It seems tslog fixed the issue in 4.9.0: fullstack-build/tslog#227 (comment) I checked by manually overriding tslog's version and it does indeed resolve my issue.

Do you want me to update this PR to upgrade to that version instead of downgrading? Or open a new PR entirely?

Hey @justinsmid, yeah lets upgrade to 4.9.0

@siddhsuresh siddhsuresh changed the title Downgrade tslog dependency from 4.8.2 to 4.7.4 Upgrade tslog dependency from 4.8.2 to 4.9.0 Aug 14, 2023
@siddhsuresh siddhsuresh merged commit 82649f3 into blitz-js:main Aug 14, 2023
@blitzjs-bot
Copy link
Contributor

Added @justinsmid contributions for doc and code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tslog error when logging error with multiple constructor arguments
4 participants