Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: windows slash correction for rpc resolvers #4269

Merged
merged 7 commits into from
Jan 4, 2024

Conversation

siddhsuresh
Copy link
Member

@siddhsuresh siddhsuresh commented Jan 3, 2024

Closes: #4265

What are the changes and their implications?

Add slash to both arguments of __internal_addBlitzRpcResolver

Bug Checklist

  • Changeset added (run pnpm changeset in the root directory)

Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: 83dfbb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@blitzjs/rpc Patch
blitz Patch
next-blitz-auth Patch
@blitzjs/next Patch
@blitzjs/auth Patch
@blitzjs/codemod Patch
@blitzjs/config Patch
@blitzjs/generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddhsuresh siddhsuresh removed the request for review from flybayer January 3, 2024 17:01
@siddhsuresh
Copy link
Member Author

!preview fix-windows-rpc

@siddhsuresh
Copy link
Member Author

!preview fix-windows-rpc

@siddhsuresh
Copy link
Member Author

!preview fix-windows-rpc

@blitz-js blitz-js deleted a comment from github-actions bot Jan 4, 2024
@siddhsuresh
Copy link
Member Author

!preview fix-windows-rpc

@blitz-js blitz-js deleted a comment from github-actions bot Jan 4, 2024
@siddhsuresh siddhsuresh requested a review from flybayer January 4, 2024 08:29
@kodiakhq kodiakhq bot merged commit e8fd12e into main Jan 4, 2024
29 of 30 checks passed
@kodiakhq kodiakhq bot deleted the siddharth/fix-unicode-rpc branch January 4, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

rpc resolver paths break
3 participants