Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java builds can miss file changes #3937

Closed
matt2e opened this issue Jan 8, 2025 · 0 comments · Fixed by #3939
Closed

Java builds can miss file changes #3937

matt2e opened this issue Jan 8, 2025 · 0 comments · Fixed by #3939
Assignees
@matt2e
Labels
jvm

Comments

@matt2e
Copy link
Collaborator

matt2e commented Jan 8, 2025 •
edited
Loading

Steps to repro

  • In a java code file add some invalid code
  • Run ftl dev <path to java module(s)>
  • Wait for initial build to fail
  • Update the java file + save
  • Update the java file + save (while ftl is building the module)
  • FTL build will not happen (expected new build to be kicked off immediately)
  • Update the java file + save
  • FTL build will happen
@matt2e matt2e added the jvm label Jan 8, 2025
@github-actions github-actions bot added the triage Issue needs triaging label Jan 8, 2025
This was referenced Jan 8, 2025
Open
Open
@matt2e matt2e changed the title Java build can get stuck Java builds can miss file changes Jan 8, 2025
@matt2e matt2e self-assigned this Jan 8, 2025
@github-actions github-actions bot removed the triage Issue needs triaging label Jan 8, 2025
@matt2e matt2e mentioned this issue Jan 8, 2025
Merged
matt2e added a commit that referenced this issue Jan 8, 2025
@matt2e
fix: jvm plugin watches for file changes while building (#3939)
a9d1911 
Quarkus also watches for changes, but if the initial build fails we need
to detect file changes ourselves.
Previously we only started watching for changes after the initial build
failed, which meant changes made after the initial build started but
before it failed were not detected.
fixes #3937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt2e matt2e

Labels
jvm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: jvm plugin watches for file changes while building block/ftl
1 participant
@matt2e