Skip to content

Commit

Permalink
Merge pull request #3479 from blockchain/fix/FWN-719
Browse files Browse the repository at this point in the history 
fix(recurring buy): fixes grammer and design issues with explainer text
  • Loading branch information
Andrew Schneider authored Aug 17, 2021
2 parents 32196cd + 0545687 commit 7ee143a
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 19 deletions.
8 changes: 4 additions & 4 deletions packages/blockchain-wallet-v4-frontend/src/assets/locales/index.d.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1232,11 +1232,11 @@ type MessagesType = {
'modals.recurringbuys.notification.page_2.title': 'The strategy is pretty simple'
'modals.recurringbuys.notification.page_2.description': 'Invest the same amount every week'

'modals.recurringbuys.notification.page_3.title': 'When the price goes down,'
'modals.recurringbuys.notification.page_3.description': 'You’ll buy more crypto.'
'modals.recurringbuys.notification.page_3.title': 'When the price goes down'
'modals.recurringbuys.notification.page_3.description': 'You’ll buy more crypto'

'modals.recurringbuys.notification.page_4.title': 'When the price goes up,'
'modals.recurringbuys.notification.page_4.description': 'You’ll buy less.'
'modals.recurringbuys.notification.page_4.title': 'When the price goes up'
'modals.recurringbuys.notification.page_4.description': 'You’ll buy less'

'modals.recurringbuys.notification.page_5.title': 'But does it work?'
'modals.recurringbuys.notification.page_5.description': 'Over the past 5 years, buying Bitcoin every week performed better than timing the market'
Expand Down
31 changes: 16 additions & 15 deletions packages/blockchain-wallet-v4-frontend/src/modals/RecurringBuys/Notifications/index.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ const SlideStart = styled(Slide)`

const SlideContent = styled.div`
padding: 0 40px;
text-align: center;
`

const SyncIconWrapper = styled.div`
Expand Down Expand Up @@ -94,13 +95,13 @@ class Notifications extends PureComponent<Props, State> {
<AnimatedCarousel stepChange={this.stepChange}>
<Slide>
<SlideContent>
<Text size='32px' weight={600} color='grey900' style={{ marginBottom: '40px' }}>
<Text size='24px' weight={600} color='grey900'>
<FormattedMessage
id='modals.recurringbuys.notification.page_1.title'
defaultMessage='Instead of timing the market, many smart investors use'
/>
</Text>
<Text size='32px' weight={600} color='blue600' lineHeight='40px'>
<Text size='24px' weight={600} color='blue600' lineHeight='40px'>
<FormattedMessage
id='modals.recurringbuys.notification.page_1.description'
defaultMessage='Dollar cost averaging'
Expand All @@ -110,13 +111,13 @@ class Notifications extends PureComponent<Props, State> {
</Slide>
<SlideStart>
<SlideContent>
<Text size='32px' weight={600} color='grey900' style={{ marginBottom: '40px' }}>
<Text size='24px' weight={600} color='grey900'>
<FormattedMessage
id='modals.recurringbuys.notification.page_2.title'
defaultMessage='The strategy is pretty simple'
/>
</Text>
<Text size='32px' weight={600} color='blue600' lineHeight='40px'>
<Text size='24px' weight={600} color='blue600' lineHeight='40px'>
<FormattedMessage
id='modals.recurringbuys.notification.page_2.description'
defaultMessage='Invest the same amount every week'
Expand All @@ -126,51 +127,51 @@ class Notifications extends PureComponent<Props, State> {
</SlideStart>
<SlideStart>
<SlideContent>
<Text size='32px' weight={600} color='grey900' style={{ marginBottom: '40px' }}>
<Text size='24px' weight={600} color='grey900'>
<FormattedMessage
id='modals.recurringbuys.notification.page_3.title'
defaultMessage='When the price goes down,'
defaultMessage='When the price goes down'
/>
</Text>
<Text size='32px' weight={600} color='blue600' lineHeight='40px'>
<Text size='24px' weight={600} color='blue600' lineHeight='40px'>
<FormattedMessage
id='modals.recurringbuys.notification.page_3.description'
defaultMessage='You’ll buy more crypto.'
defaultMessage='You’ll buy more crypto'
/>
</Text>
</SlideContent>
</SlideStart>
<SlideStart>
<SlideContent>
<Text size='32px' weight={600} color='grey900' style={{ marginBottom: '40px' }}>
<Text size='24px' weight={600} color='grey900'>
<FormattedMessage
id='modals.recurringbuys.notification.page_4.title'
defaultMessage='When the price goes up,'
defaultMessage='When the price goes up'
/>
</Text>
<Text size='32px' weight={600} color='blue600' lineHeight='40px'>
<Text size='24px' weight={600} color='blue600' lineHeight='40px'>
<FormattedMessage
id='modals.recurringbuys.notification.page_4.description'
defaultMessage='You’ll buy less.'
defaultMessage='You’ll buy less'
/>
</Text>
</SlideContent>
</SlideStart>
<Slide>
<SlideContent>
<Text size='32px' weight={600} color='grey900' style={{ marginBottom: '40px' }}>
<Text size='24px' weight={600} color='grey900' style={{ marginBottom: '40px' }}>
<FormattedMessage
id='modals.recurringbuys.notification.page_5.title'
defaultMessage='But does it work?'
/>
</Text>
<Text size='32px' weight={600} color='grey900' lineHeight='40px'>
<Text size='24px' weight={600} color='grey900' lineHeight='40px'>
<FormattedMessage
id='modals.recurringbuys.notification.page_5.description'
defaultMessage='Over the past 5 years, buying Bitcoin every week performed better than timing the market'
/>
</Text>
<Text size='32px' weight={600} color='blue600' lineHeight='40px'>
<Text size='24px' weight={600} color='blue600' lineHeight='40px'>
<FormattedMessage
id='modals.recurringbuys.notification.page_5.disclaimer'
defaultMessage='82% of the time.'
Expand Down

0 comments on commit 7ee143a

Please sign in to comment.