Moved example into owner package. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentinlesceller
suggested changes
Jul 7, 2020
There was a problem hiding this comment.
Thank you so much for the PR @asciiu.
Small comments below but overall very nice !! Tested and works great.
Finally what do you think about renaming the package to client instead of owner (since we include the Node API and maybe later the foreign API)?
Co-authored-by: Quentin Le Sceller <[email protected]>
Co-authored-by: Quentin Le Sceller <[email protected]>
|
I figured moving this stuff into the "owner" package and naming the other client lib "foreign" to match the rust api. I'm fine with whatever naming convention you want though since this isn't my project. |
quentinlesceller
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Thank you @asciiu :) did a quick change for client package name since the directory include foreign and owner API.
Also took the opportunity to fix the CI 😛
Merging once CI pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed example package to owner and implemented the owner accounts api method.