feat: add GET_PROTOCOL_PARAMETERS #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowbackspace
requested changes
Nov 25, 2024
| test(fixture.testName, async () => { | ||
| const ws = getWebSocketClient(); | ||
| const { cost_models, ...data } = await ws.sendAndWait('GET_PROTOCOL_PARAMETERS'); | ||
| expect(data).toMatchObject(fixture.result); |
There was a problem hiding this comment.
Suggested change
| expect(data).toMatchObject(fixture.result); | |
| expect(data).toStrictEqual(fixture.result); |
I prefer using toStrictEqual in this case. The fixture could be missing some data (as it is now missing cost_models) which could go unnoticed with a less strict assertion.
There was a problem hiding this comment.
c9ce170 should solve this
| PlutusV2: expect.arrayContaining([expect.any(Number)]), | ||
| PlutusV3: expect.arrayContaining([expect.any(Number)]), | ||
| }, | ||
| price_mem: 0.0577, |
There was a problem hiding this comment.
I wasn't able to find a way to describe the cost_models object with combinations of expects: the object is explicitly checked in the test file.
c9ce170 should solve this
There was a problem hiding this comment.
Let's begin with the strictest version and gradually relax the requirements if needed.
I added checking whole cost_models d976784
iccicci
force-pushed
the
feat/get_protocol_parameters
branch
from
75c3a44 to
c9ce170
Compare
slowbackspace
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #254