Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CSV export of epoch transactions for address #11195

Merged
merged 9 commits into from
Dec 3, 2024

Conversation

fedor-ivn
Copy link
Contributor

@fedor-ivn fedor-ivn commented Nov 13, 2024

Closes #11194, closes #11201.

Motivation

The Celo community requested that validators retain the ability to export epoch transaction data when migrating to our instance. This feature is crucial for calculating earnings from participating in validator groups within the Celo protocol.

For context, the legacy Celo explorer provides a similar feature on the validator address page, where users can generate a CSV export for this data.

Changelog

Enhancements

  • Introduced a new /api/v1/celo-election-rewards-csv endpoint and the AddressElectionRewardsCsvExporter module.

⚠️ Note: The exported table does not preserve the "LockedGold" and "VotingGold" fields, since this data is not indexed.

Bug fixes

  • Pagination of election rewards when the type of reward is delegated_payment

Checklist for your Pull Request (PR)

  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so by submitting a PR to docs repository.
  • If I added/changed/removed ENV var, I submitted a PR to docs repository to update the list of env vars and I updated the version to master in the Version column. If I removed variable, I added it to Deprecated ENV Variables page. After merging docs PR, changes will be reflected in these pages.
  • If I added new DB indices, I checked, that they are not redundant, with PGHero or other tools.
  • If I added/removed chain type, I modified the Github CI matrix and PR labels accordingly.

@fedor-ivn fedor-ivn added this to the 7.0.0 milestone Nov 13, 2024
@fedor-ivn fedor-ivn requested a review from a team November 13, 2024 20:44
@fedor-ivn fedor-ivn force-pushed the fi-celo-epoch-transactions-csv-export branch from 4335fd0 to a10be79 Compare November 14, 2024 08:32
@fedor-ivn fedor-ivn force-pushed the fi-celo-epoch-transactions-csv-export branch from a10be79 to 32931ba Compare November 18, 2024 16:48
@fedor-ivn fedor-ivn force-pushed the fi-celo-epoch-transactions-csv-export branch from a0b3065 to 4ae9224 Compare November 19, 2024 13:44
@fedor-ivn fedor-ivn force-pushed the fi-celo-epoch-transactions-csv-export branch from 8079151 to 32b5bc1 Compare November 20, 2024 13:40
@vbaranov vbaranov merged commit 50edb2e into master Dec 3, 2024
17 checks passed
@vbaranov vbaranov deleted the fi-celo-epoch-transactions-csv-export branch December 3, 2024 08:24
@vbaranov vbaranov modified the milestones: 7.0.0, 6.10.0 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination in election rewards for delegated payments Celo: CSV export of epoch transactions for address
3 participants