Resolve a circular import error in obscure configuarations. #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you need to approve the workflows |
Ah, I am using the new Github merge thing and the "Approve workflow" button doesn't appear in that version :S |
|
Do you mind ammending the commit with |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
==========================================
- Coverage 92.99% 92.91% -0.08%
==========================================
Files 95 95
Lines 11675 11678 +3
Branches 406 407 +1
==========================================
- Hits 10857 10851 -6
- Misses 818 827 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
auto-merge was automatically disabled
January 12, 2025 14:47
Head branch was pushed to by a user without write access
jhance
force-pushed
the
obscure-circular-dep
branch
from
a07e6c2 to
a2f2fb2
Compare
Signed-off-by: Jared Hance <[email protected]>
pablogsal
force-pushed
the
obscure-circular-dep
branch
from
a2f2fb2 to
5c8ec39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #704.
It is unclear why this error is specific to obscure configurations or
what is triggering it, but the overhead of fixing it is small anyhow.
We have been using this patch internally to resolve the issue.