Skip to content

Commit

Permalink
chore(firestore): Fix some rubocop warnings (googleapis#25792)
Browse files Browse the repository at this point in the history
  • Loading branch information
dazuma authored Apr 25, 2024
1 parent 655760f commit 5191810
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ def next?
def next
return nil unless next?
ensure_client!
grpc = @client.service.list_documents @parent, @collection_id, token: token, max: @max, \
read_time: @read_time
grpc = @client.service.list_documents @parent, @collection_id,
token: token, max: @max, read_time: @read_time
self.class.from_grpc grpc, @client, @parent, @collection_id, @max, read_time: @read_time
end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ def persist resume_token, read_time
def changes?
# Act like there are changes if we have never run before
return true if @old_order.nil?
added_paths, deleted_paths, changed_paths = \
change_paths current_order, @old_order
added_paths, deleted_paths, changed_paths = change_paths current_order, @old_order
added_paths.any? || deleted_paths.any? || changed_paths.any?
end

Expand Down Expand Up @@ -217,8 +216,7 @@ def change_paths new_order, old_order
def build_changes new_order, old_order
new_paths = new_order.keys
old_paths = old_order.keys
added_paths, deleted_paths, changed_paths = \
change_paths new_order, old_order
added_paths, deleted_paths, changed_paths = change_paths new_order, old_order

changes = deleted_paths.map do |doc_path|
build_deleted_doc_change doc_path, old_paths
Expand Down

0 comments on commit 5191810

Please sign in to comment.